Rework vendoring #846
Merged
Rework vendoring #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo warns about this.
In particular now that we have a `git` dependency, this turns out to reveal some deficiencies in how e.g. the Fedora RPM vendoring support works. Sync the code from containers/bootc@58fa21e
- Use `rust-%{crate}` for name because that's what Fedora
does; the previous spec file sync was just broken
- Use a source archive generated from git, not a `.crate`; we
will stop publishing to crates.io.
Signed-off-by: Colin Walters <[email protected]>
jmarrero
reviewed
Feb 11, 2025
| @@ -2,14 +2,14 @@ | |||
|
|
|||
| %global crate bootupd | |||
|
|
|||
| Name: bootupd | |||
| Name: rust-%{crate} | |||
There was a problem hiding this comment.
this will not create a big issue in Fedora/RHEL? Changing the package name?
There was a problem hiding this comment.
This is just the source name, and it's already named this in Fedora https://src.fedoraproject.org/rpms/rust-bootupd but it isn't in RHEL https://gitlab.com/redhat/centos-stream/rpms/bootupd
There was a problem hiding this comment.
See #838 which introduced this change
There was a problem hiding this comment.
IOW, one pain point we are going to need to eat here is that because it'd be hugely painful (AFAIK) to rename the source package in RHEL, we will have spec file divergence for the forseeable future there.
jmarrero
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xtask: Fix deprecated
default_featurescargo warns about this.
xtask: Sync with bootc
In particular now that we have a
gitdependency, this turnsout to reveal some deficiencies in how e.g. the Fedora RPM
vendoring support works.
Sync the code from containers/bootc@58fa21e
contrib/rpm: Sync vendor config from bootc
contrib/rpm: Two more fixes
rust-%{crate}for name because that's what Fedoradoes; the previous spec file sync was just broken
.crate; wewill stop publishing to crates.io.
Signed-off-by: Colin Walters [email protected]