Incompatibility with nette/forms v3.1.0 - Undefined index: perPage

[elring]

Hello :)
After today upgrade, I got Undefined index: perPage - File: .../vendor/ublaboo/datagrid/src/DataGrid.php:1509
1509: $this->saveSessionData('_grid_perPage', $values['perPage']);
Error occurs after pressing Save button in inline edit.

The problem is not in new version of Datagrid, but in some incompatibility with new Nette Forms (which new version is from 2020/01/19). It appears after upgrade nette/forms from v3.0.7 to v3.1.0. Datagrid v6.6.1 with Nette 3.0.7 is ok, with Nette 3.1.0 is not.

Problem is (probably) in nette/forms BC break mentioned in release notes (Form::getValues() returns only controls in scope (BC break)). Inline editor submit buttons don't validate the perPage control, so new nette/forms doesn't return it's value.

[paveljanda]

Looking into that 👍

[paveljanda]

Fixed in https://github.com/contributte/datagrid/releases/tag/v6.8.0