Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lifecycle logs as Debug instead of Info #610

Merged
merged 1 commit into from
Aug 8, 2020
Merged

lifecycle logs as Debug instead of Info #610

merged 1 commit into from
Aug 8, 2020

Conversation

MichaelSp
Copy link
Contributor

@MichaelSp MichaelSp commented Jul 31, 2020 •
edited
Loading

The life-cycle messages should not have the same level as the update messages.

Why?

I receive a (mail-) notification for every run even if no image is changed:

2020-07-31 06:44:33 (info): Executing pre-check command.

But I only want to receive a notification if something changed:

2020-07-20 06:44:44 (info): Found new traefik:v2.2 image (sha256:7c992081f52423e325bd12debf0edcb4f7cfa398683c26f99c00112ec14e1ab9)

@MichaelSp
lifecycle logs as Debug instead of Info
8e3ac9d 
The life-cycle messages should not have the same level as the update messages.

Why?
I receive a (mail-) notification for every run even if no image is changed: 
```
2020-07-31 06:44:33 (info): Executing pre-check command.
```

But I only want to receive a notification if something changed:
```
2020-07-20 06:44:44 (info): Found new traefik:v2.2 image (sha256:7c992081f52423e325bd12debf0edcb4f7cfa398683c26f99c00112ec14e1ab9)
```
piksel
piksel approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of hard to balance what should be printed in the default output and what should be included in the notifications, but I do agree with this one. I don't think it's necessarily helpful to print these messages when running without debug enabled.

@simskij simskij merged commit f6c1989 into containrrr:master Aug 8, 2020
@simskij
Copy link
Member

simskij commented Aug 8, 2020

Thanks for the contribution! 🙇

@simskij
Copy link
Member

simskij commented Aug 8, 2020

@all-contributors add @MichaelSp for code

@allcontributors allcontributors bot mentioned this pull request Aug 8, 2020
Merged
@allcontributors
Copy link
Contributor

@simskij

I've put up a pull request to add @MichaelSp! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piksel piksel piksel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelSp @simskij @piksel