[incubating][CMakeDeps] Apple Frameworks #17725
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franramirez688
commented
Feb 7, 2025
| breakpoint() | ||
| assert "/System/Library/Frameworks/Foundation.framework;" in client.out | ||
| assert "/System/Library/Frameworks/CoreServices.framework;" in client.out | ||
| assert "/System/Library/Frameworks/CoreFoundation.framework" in client.out |
There was a problem hiding this comment.
Working on that, it's just a copy&paste for now. Adapting this one and adding more 😁
franramirez688
force-pushed
the
frm/package_frameworks
branch
from
c7246cc to
b4b5fb9
Compare
AbrilRBS
reviewed
Feb 7, 2025
Co-authored-by: Abril Rincón Blanco <[email protected]>
memsharded
reviewed
Feb 7, 2025
| @@ -346,7 +360,12 @@ def _template(self): | |||
| {% if lib_info.get("system_libs") %} | |||
| target_link_libraries({{lib}} INTERFACE {{lib_info["system_libs"]}}) | |||
| {% endif %} | |||
|
|
|||
| {% if lib_info.get("frameworks") %} | |||
| target_link_libraries({{lib}} INTERFACE {{lib_info["frameworks"]}}) | |||
There was a problem hiding this comment.
Instead of defining an INTERFACE target, it would be better to follow https://cmake.org/cmake/help/latest/prop_tgt/IMPORTED_IMPLIB.html and do:
- Define a proper IMPORTED SHARED target
- Define its IMPORTED_LOCATION and IMPORTED_IMPLIB
It is not a big deal that it requires CMake>3.27, in https://github.com/conan-io/conan/pull/17459/files I am already requiring CMake>3.27 for some features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Added complete Apple Frameworks management to new CMakeDeps.
Changelog: Feature: Added new
cpp_info.package_frameworkstocpp_info.Docs: omit
Closes: #13017
Closes: #10140
Closes: #17224