Added in_range method to Version class #17658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
requested changes
Jan 29, 2025
perseoGI
changed the title
memsharded
reviewed
Jan 29, 2025
conan/internal/model/version.py
Outdated
Comment on lines
202
to
203
| if version_range.startswith("[") and version_range.endswith("]"): | ||
| version_range = version_range[1:-1] |
There was a problem hiding this comment.
No, not necessary to provide 2 different ways to achieve exactly the same.
Lets go first with the simpler, not using [ ] one.
The [ ] syntax is for requires to differentiate regular fixed version from version ranges.
There was a problem hiding this comment.
Okay, removed then!
I still think we may support it through the VersionRange constructor but I don't know if that [<version_range>] syntax is exclusively for requires or if could be used in a different context.
In that case, it may seem strange for users. At least it happens to me when testing!
franramirez688
approved these changes
Jan 29, 2025
memsharded
approved these changes
Jan 29, 2025
AbrilRBS
approved these changes
Jan 29, 2025
Co-authored-by: Abril Rincón Blanco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Introducing
in_rangemethod in Version which allows comparing against version ranges.Docs: conan-io/docs#3996
developbranch, documenting this one.