Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SELECT FOR UPDATE variants for Postgres and MySql #45

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

aboisvert
Copy link
Contributor

No description provided.

Copy link
Member

@lihaoyi lihaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just re-comment out the pprint.logs and run scalafix/doc-generation and I can merge and publish it

@aboisvert aboisvert force-pushed the aboisvert/select-for-update branch from b7a9f9e to d513877 Compare November 20, 2024 16:03
@aboisvert aboisvert force-pushed the aboisvert/select-for-update branch from d513877 to 1843286 Compare November 20, 2024 16:57
@aboisvert
Copy link
Contributor Author

All green, this looks ready to merge now. (No rush on my side, just mentioning.)

@lihaoyi lihaoyi merged commit 5c3141c into com-lihaoyi:main Nov 21, 2024
6 checks passed
@lihaoyi
Copy link
Member

lihaoyi commented Nov 21, 2024

Tagged 0.1.12 containing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants