Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

关于 3.8.6 分支上 几个代码的 疑惑 #18368

Open
finscn opened this issue Feb 24, 2025 · 0 comments
Open

关于 3.8.6 分支上 几个代码的 疑惑 #18368

finscn opened this issue Feb 24, 2025 · 0 comments
Labels
Bug Needs Triage Needs to be assigned by the team

Comments

@finscn
Copy link
Contributor

finscn commented Feb 24, 2025

Cocos Creator version

3.8.6

System information

all

Issue description

疑惑1 :

markForUpdateRenderData() 为什么改为私有的?
之前为了实现某些功能 必须要开发者手动调用它(比如动态修改 spriteFrame后) , 变私有后, 这类问题怎么解决呢?
不需要手动调用了?

疑惑2 :

很多方法里 为什么要给 this 使用毫无必要的别名变量self ?
这种做法是违反你们自己定制的研发规范的.
提示错误 Unexpected aliasing of 'this' to local variable.eslint[@typescript-eslint/no-this-alias](https://typescript-eslint.io/rules/no-this-alias)
这些 self 有什么意义? 为什么要使用这种别名?

疑惑3:

你们新加的一些代码, 也直接违反你们的 eslint规则和编码规范.
之前你们不是说"老代码符合规范要慢慢来 很麻烦", 但是"新写的代码会遵守规则规范"吗?
咋说到做不到呢? 这样下去 你们的代码啥时候才能易读易维护啊.

Relevant error log output

No response

Steps to reproduce

.

Minimal reproduction project

No response

@finscn finscn added Bug Needs Triage Needs to be assigned by the team labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Needs Triage Needs to be assigned by the team
Projects
None yet
Development

No branches or pull requests

1 participant