Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal dependency is considered external #195

Closed
haraldradi opened this issue Dec 11, 2023 · 3 comments
Closed

internal dependency is considered external #195

haraldradi opened this issue Dec 11, 2023 · 3 comments

Comments

@haraldradi
Copy link

gradle.dependencies.expose-api: Do not expose external dependencies as 'api' without good reason.: 2 issue(s) (0 suppressed):
  8fe785d4: Dependency 'io.cloudflight.conto:conto-signature-api' in project ':contract-client' is transitively exposed as 'api'.
  a58dc349: Dependency 'io.cloudflight.conto:conto-signature-api' in project ':contract-client' transitively exposes all runtime dependencies. Declare the dependency as "api ('io.cloudflight.conto:conto-signature-api') { transitive = false }" or add a plausible verification reason if this is intentional.
  see https://docs.cloudflight.io/io.cloudflight.cleancode.verifier/cleancode-verifier-gradle/0.13.1#dependencies-expose-api for more details and reasoning behind

A dependency built in our own environment with the help of the gradle autoconfigure plugin shall not be considered "external"

@klu2
Copy link
Contributor

klu2 commented Dec 11, 2023

You are referring to code of an internal library of cloudflight. This does not come from this opensource repository on github

@rspiegl
Copy link
Contributor

rspiegl commented Dec 11, 2023

As it concerns a different repo and not this one I close this issue

@rspiegl rspiegl closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
@haraldradi
Copy link
Author

I'm experiencing a bug that was introduced by pulling things apart. I don't think that this can be solely connected to only the internal part, nevertheless here is the link to the jira ticket for later reference: https://jira.cloudflight.io/browse/CBP-543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants