Skip to content

Commit 3241d11

Browse files
committed
Fix up tests
1 parent 990b116 commit 3241d11

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

pkg/api/cache_test.go

+12-6
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,17 @@ func TestCacheResponse(t *testing.T) {
3131

3232
cacheDir := filepath.Join(t.TempDir(), "gh-cli-cache")
3333

34-
httpClient, _ := NewHTTPClient(
34+
httpClient, err := NewHTTPClient(
3535
ClientOptions{
36+
Host: "github.com",
37+
AuthToken: "token",
3638
Transport: fakeHTTP,
3739
EnableCache: true,
3840
CacheDir: cacheDir,
3941
LogIgnoreEnv: true,
40-
})
42+
},
43+
)
44+
assert.NoError(t, err)
4145

4246
do := func(method, url string, body io.Reader) (string, error) {
4347
req, err := http.NewRequest(method, url, body)
@@ -57,7 +61,6 @@ func TestCacheResponse(t *testing.T) {
5761
}
5862

5963
var res string
60-
var err error
6164

6265
res, err = do("GET", "http://example.com/path", nil)
6366
assert.NoError(t, err)
@@ -112,13 +115,17 @@ func TestCacheResponseRequestCacheOptions(t *testing.T) {
112115

113116
cacheDir := filepath.Join(t.TempDir(), "gh-cli-cache")
114117

115-
httpClient, _ := NewHTTPClient(
118+
httpClient, err := NewHTTPClient(
116119
ClientOptions{
120+
Host: "github.com",
121+
AuthToken: "token",
117122
Transport: fakeHTTP,
118123
EnableCache: false,
119124
CacheDir: cacheDir,
120125
LogIgnoreEnv: true,
121-
})
126+
},
127+
)
128+
assert.NoError(t, err)
122129

123130
do := func(method, url string, body io.Reader) (string, error) {
124131
req, err := http.NewRequest(method, url, body)
@@ -140,7 +147,6 @@ func TestCacheResponseRequestCacheOptions(t *testing.T) {
140147
}
141148

142149
var res string
143-
var err error
144150

145151
res, err = do("GET", "http://example.com/path", nil)
146152
assert.NoError(t, err)

0 commit comments

Comments
 (0)