Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing firewalls with no rules doesn't display relevant information #447

Closed
fernando-villalba opened this issue Aug 8, 2024 · 1 comment · Fixed by #457
Closed

Listing firewalls with no rules doesn't display relevant information #447

fernando-villalba opened this issue Aug 8, 2024 · 1 comment · Fixed by #457

Comments

@fernando-villalba
Copy link
Contributor

Issue

Listing firewalls with no rules doesn't display helpful or relevant information

  1. Create a firewall without rules
civo fw create test-issue --create-rules=false 
  1. List the firewall without rules
civo firewall rule ls test-issue 

Output:

image

Acceptance Criteria

The output provided above is not helpful. Instead, the message should be something like:

Firewall test-issue has no rules, to create rules use command civo firewall rule create, for example:
civo firewall rule create test-issue -c '0.0.0.0/0' -s 443 -e 443 -l HTTPS

Or something like that

@Praveen005
Copy link
Contributor

Hi Team,

for this issue, adding a check to see if firewallRules slice is empty and erroring out with the above suggested message would be okay I believe.

Screenshot 2024-08-12 205407

Result:

Screenshot 2024-08-12 205108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants