[TASK] Adapt extbase view resolver to TYPO3 13

Remove the outdated extbase view adapter and allow users to override
extbase views with custom processors.

Author: SomeBdyElse

Classes/DependencyInjection/AsExtbaseProcessorCompilerPass.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace PrototypeIntegration\PrototypeIntegration\DependencyInjection;
+
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;
+
+class AsExtbaseProcessorCompilerPass implements CompilerPassInterface
+{
+    public function process(ContainerBuilder $container): void
+    {
+        try {
+            $definition = $container->findDefinition('PrototypeIntegration\PrototypeIntegration\View\ExtbaseProcessorRegistry');
+        } catch (ServiceNotFoundException $e) {
+            return;
+        }
+
+        foreach ($container->findTaggedServiceIds('pti.extbase_processors') as $processorClassname => $tags) {
+            $container->getDefinition($processorClassname)->setPublic(true);
+            foreach ($tags as $attributes) {
+                $definition->addMethodCall('addOverride', [
+                    $attributes['controller'],
+                    $attributes['action'],
+                    $processorClassname,
+                    $attributes['template'],
+                ]);
+            }
+        }
+    }
+}

Classes/DependencyInjection/Attribute/AsExtbaseProcessor.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace PrototypeIntegration\PrototypeIntegration\DependencyInjection\Attribute;
+
+#[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
+class AsExtbaseProcessor
+{
+    public function __construct(
+        public string $controller,
+        public string $action,
+        public ?string $template = null,
+    ) {
+    }
+}

Classes/View/DefaultViewResolver.php

@@ -6,7 +6,7 @@
 
 use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\CMS\Extbase\Configuration\ConfigurationManager;
+use TYPO3\CMS\Extbase\Mvc\RequestInterface;
 use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
 
 class DefaultViewResolver implements ViewResolverInterface
@@ -29,14 +29,11 @@ public function getViewForContentObject(
     }
 
     public function getViewForExtbaseAction(
-        string $controllerObjectName,
-        string $actionName,
-        string $format,
-        ?string $template
+        RequestInterface $extbaseRequest,
+        ?string $template = null,
     ): PtiViewInterface {
         // Allow the CompoundProcessor to force json output
-        $configurationManager = GeneralUtility::makeInstance(ConfigurationManager::class);
-        $contentObject = $configurationManager->getContentObject();
+        $contentObject = $extbaseRequest->getAttribute('currentContentObject');
 
         $ptiForceView = $contentObject?->data['_pti_format'] ?? null;
         if (
@@ -58,6 +55,7 @@ public function getViewForExtbaseAction(
         if (isset($format) && $format === 'json') {
             return $this->getJsonView();
         }
+
         return $this->getDefaultView($template);
     }
 

Classes/View/Event/ExtbaseViewAdapterVariablesConvertedEvent.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace PrototypeIntegration\PrototypeIntegration\View;
+
+class ExtbaseProcessorRegistry
+{
+    public function __construct(
+        protected array $overrides = [],
+    ) {
+    }
+
+    public function addOverride(
+        string $controller,
+        string $action,
+        string $processorClassName,
+        ?string $template = null,
+    ) {
+        $this->overrides[$controller][$action] = [
+            'processors' => [$processorClassName],
+            'template' => $template,
+        ];
+    }
+
+    public function getOverrides(): array
+    {
+        return $this->overrides;
+    }
+
+    /** array<processors: string[], template?: ?string> */
+    public function getProcessorForControllerAndAction(string $controller, string $action): ?array
+    {
+        return $this->overrides[$controller][$action] ?? null;
+    }
+}

Classes/View/ExtbaseProcessorRegistry.php

@@ -4,8 +4,6 @@
 
 namespace PrototypeIntegration\PrototypeIntegration\View;
 
-use TYPO3\CMS\Core\Utility\Exception\NotImplementedMethodException;
-
 class JsonView implements PtiViewInterface
 {
     protected array $variables = [];
@@ -19,14 +17,4 @@ public function setVariables($variables): void
     {
         $this->variables = $variables;
     }
-
-    public function renderSection($sectionName, array $variables = [], $ignoreUnknown = false)
-    {
-        throw new NotImplementedMethodException('renderSection not implemented for JsonView', 1690795638213);
-    }
-
-    public function renderPartial($partialName, $sectionName, array $variables, $ignoreUnknown = false)
-    {
-        throw new NotImplementedMethodException('renderSection not implemented for JsonView', 1690795646994);
-    }
 }

Classes/View/ExtbaseViewAdapter.php

@@ -5,14 +5,14 @@
 namespace PrototypeIntegration\PrototypeIntegration\View;
 
 use PrototypeIntegration\PrototypeIntegration\Processor\PtiDataProcessor;
-use TYPO3\CMS\Core\Utility\Exception\NotImplementedMethodException;
-use TYPO3Fluid\Fluid\View\AbstractView;
-use TYPO3Fluid\Fluid\View\ViewInterface;
+use TYPO3\CMS\Core\View\ViewInterface;
 
-class ViewAdapter extends AbstractView implements ViewInterface
+class ViewAdapter implements ViewInterface
 {
     protected ?array $settings;
 
+    protected array $variables = [];
+
     /**
      * @param PtiDataProcessor[] $dataProcessors
      */
@@ -22,10 +22,7 @@ public function __construct(
     ) {
     }
 
-    /**
-     * @return string The rendered view
-     */
-    public function render()
+    public function render(string $templateFileName = ''): string
     {
         $variables = $this->variables;
         foreach ($this->dataProcessors as $dataProcessor) {
@@ -39,13 +36,15 @@ public function render()
         return $this->view->render();
     }
 
-    public function renderSection($sectionName, array $variables = [], $ignoreUnknown = false)
+    public function assign(string $key, mixed $value): self
     {
-        throw new NotImplementedMethodException('', 1691406217099);
+        $this->variables[$key] = $value;
+        return $this;
     }
 
-    public function renderPartial($partialName, $sectionName, array $variables, $ignoreUnknown = false)
+    public function assignMultiple(array $values): self
     {
-        throw new NotImplementedMethodException('', 1691406221493);
+        $this->variables = array_replace_recursive($this->variables, $values);
+        return $this;
     }
 }