Skip to content

Commit dd4cb91

Browse files
committed
Merge remote-tracking branch 'Upstream/develop' into Upstream_release
2 parents 5b8ddcd + 23cd103 commit dd4cb91

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

android/libraries/TweetLanesCore/res/xml/changelog.xml

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@
44
<change>Feature - Large media previews &amp; option to turn off media previews</change>
55
<change>Feature - Added option to use display urls rather than full URLs</change>
66
<change>Feature - Added auto complete mid status rather than needing to be the last word in compose box</change>
7-
<change>Feature - Added configuration for tweet cache size</change>
7+
<change>Feature - Added configuration for statuses cache size</change>
88
<change>Fix - Set VolScroll to be defaulted off</change>
99
<change>Fix - Update remaining characters as soon as media attached</change>
1010
<change>Fix - Rotate flip on landscape refresh</change>
1111
<change>Fix - Prevent infinite refresh loop</change>
12+
<change>Fix - Correct issue with conversations appearing under the wrong statuses</change>
1213
<change>Fix - Various errors reported by fatal crashes</change>
1314
</release>
1415
<release version="1.3.0" versioncode="55">

android/libraries/TweetLanesCore/src/com/tweetlanes/android/core/view/TweetFeedItemView.java

+10-6
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,17 @@ public void configure(TwitterStatus twitterStatus, int position, Callbacks callb
203203

204204
mConversationExpanded = showConversationView;
205205
mConversationToggle = mHolder.conversationToggle;
206+
206207
if (mConversationToggle != null) {
208+
mConversationToggle.setVisibility(GONE);
209+
if (mConversationView != null) {
210+
removeView(mConversationView);
211+
mConversationView = null;
212+
}
213+
int drawable = AppSettings.get().getCurrentTheme() == AppSettings.Theme.Holo_Dark ? R.drawable.ic_action_expand_dark
214+
: R.drawable.ic_action_expand_light;
215+
mConversationToggle.setImageDrawable(getResources().getDrawable(
216+
drawable));
207217

208218
if (twitterStatus.mInReplyToStatusId != null) {
209219
mConversationToggle.setVisibility(VISIBLE);
@@ -221,12 +231,6 @@ public void onClick(View v) {
221231
mConversationView.setVisibility(GONE);
222232
configureConversationView(socialNetType, currentAccountKey);
223233
}
224-
} else {
225-
mConversationToggle.setVisibility(GONE);
226-
if (mConversationView != null) {
227-
removeView(mConversationView);
228-
mConversationView = null;
229-
}
230234
}
231235
}
232236

0 commit comments

Comments
 (0)