Tweek to DM item view to apply fix to remove profile images when not downloading them

Author: BlythMeister

android/libraries/TweetLanesCore/src/com/tweetlanes/android/core/view/DirectMessageItemView.java

@@ -44,6 +44,43 @@
 
 public class DirectMessageItemView extends LinearLayout {
 
+    private final Path mPath = new Path();
+    private final Paint mPaint = new Paint();
+    /*
+     *
+	 */
+    private final OnTouchListener mOnTouchListener = new OnTouchListener() {
+
+        @Override
+        public boolean onTouch(View v, MotionEvent event) {
+            return mGestureDetector.onTouchEvent(event);
+        }
+    };
+    /*
+     *
+	 */
+    private final GestureDetector mGestureDetector = new GestureDetector(
+            new GestureDetector.SimpleOnGestureListener() {
+
+                @Override
+                public boolean onSingleTapConfirmed(MotionEvent e) {
+                    return mCallbacks != null && mCallbacks.onSingleTapConfirmed(DirectMessageItemView.this, mPosition);
+                }
+
+                @Override
+                public void onLongPress(MotionEvent e) {
+                    if (mCallbacks != null) {
+                        mCallbacks.onLongPress(DirectMessageItemView.this,
+                                mPosition);
+                    }
+                    // return true;
+                }
+
+                @Override
+                public boolean onDown(MotionEvent e) {
+                    return true;
+                }
+            });
     private Context mContext;
     private int mPosition;
     private TwitterDirectMessage mDirectMessage;
@@ -52,25 +89,9 @@ public class DirectMessageItemView extends LinearLayout {
     private QuickContactDivot mAvatar;
     private boolean mFullConversation;
     private ViewHolder mHolder;
-    private final Path mPath = new Path();
-    private final Paint mPaint = new Paint();
-
-    /*
-     * 
-     */
-    public interface DirectMessageItemViewCallbacks {
-
-        public boolean onSingleTapConfirmed(View view, int position);
-
-        public void onLongPress(View view, int position);
-
-        public Activity getActivity();
-
-        public LazyImageLoader getProfileImageLoader();
-    }
 
     /*
-     * 
+     *
      */
     public DirectMessageItemView(Context context) {
         super(context);
@@ -259,6 +280,8 @@ public void onClick(View v) {
             if (imageLoader != null) {
                 imageLoader.displayImage(imageUrl, mAvatar);
             }
+        } else {
+            mAvatar.setImageResource(R.drawable.ic_contact_picture);
         }
 
         mMessageBlock = mHolder.messageBlock;
@@ -273,43 +296,6 @@ public void onClick(View v) {
         }
     }
 
-    /*
-     *
-	 */
-    private final OnTouchListener mOnTouchListener = new OnTouchListener() {
-
-        @Override
-        public boolean onTouch(View v, MotionEvent event) {
-            return mGestureDetector.onTouchEvent(event);
-        }
-    };
-
-    /*
-     *
-	 */
-    private final GestureDetector mGestureDetector = new GestureDetector(
-            new GestureDetector.SimpleOnGestureListener() {
-
-                @Override
-                public boolean onSingleTapConfirmed(MotionEvent e) {
-                    return mCallbacks != null && mCallbacks.onSingleTapConfirmed(DirectMessageItemView.this, mPosition);
-                }
-
-                @Override
-                public void onLongPress(MotionEvent e) {
-                    if (mCallbacks != null) {
-                        mCallbacks.onLongPress(DirectMessageItemView.this,
-                                mPosition);
-                    }
-                    // return true;
-                }
-
-                @Override
-                public boolean onDown(MotionEvent e) {
-                    return true;
-                }
-            });
-
     public TwitterDirectMessage getDirectMessage() {
         return mDirectMessage;
     }
@@ -384,6 +370,20 @@ public void dispatchDraw(Canvas c) {
         }
     }
 
+    /*
+     *
+     */
+    public interface DirectMessageItemViewCallbacks {
+
+        public boolean onSingleTapConfirmed(View view, int position);
+
+        public void onLongPress(View view, int position);
+
+        public Activity getActivity();
+
+        public LazyImageLoader getProfileImageLoader();
+    }
+
     private static class ViewHolder {
         public ImageView replyIcon;
         public TextView authorScreenNameTextView;

android/libraries/TweetLanesCore/src/com/tweetlanes/android/core/view/UserFeedItemView.java

@@ -30,14 +30,14 @@
 
 public class UserFeedItemView extends LinearLayout {
 
+    private final Path mPath = new Path();
+    private final Paint mPaint = new Paint();
     private Context mContext;
     private TwitterUser mUser;
     private long mUserId;
     private String mUserScreenName;
     private View mMessageBlock;
     private QuickContactDivot mAvatar;
-    private final Path mPath = new Path();
-    private final Paint mPaint = new Paint();
 
     public UserFeedItemView(Context context) {
         super(context);
@@ -74,15 +74,14 @@ public void configure(TwitterUser user, int position,
         mAvatar = (QuickContactDivot) findViewById(R.id.avatar);
         if (AppSettings.get().downloadFeedImages()) {
             String imageUrl = user.getProfileImageUrl(TwitterManager.ProfileImageSize.BIGGER);
-            // UrlImageViewHelper.setUrlDrawable(avatar, imageUrl,
-            // R.drawable.ic_contact_picture);
-            // avatar.setImageURL(imageUrl);
 
             LazyImageLoader profileImageLoader = callbacks
                     .getProfileImageLoader();
             if (profileImageLoader != null) {
                 profileImageLoader.displayImage(imageUrl, mAvatar);
             }
+        } else {
+            mAvatar.setImageResource(R.drawable.ic_contact_picture);
         }
 
         mMessageBlock = findViewById(R.id.message_block);