Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cat/mad_hatter/core_plugin/settings.py #645

Closed
nicola-corbellini opened this issue Jan 2, 2024 · 2 comments
Closed

Rename cat/mad_hatter/core_plugin/settings.py #645

nicola-corbellini opened this issue Jan 2, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@nicola-corbellini
Copy link
Member

Is your feature request related to a problem? Please describe.
Similar to #633, there are two files named settings.py in the cat's folder.
The first one is related to the /settings endpoints and the second one is about the plugin's settings.
Because of the not very sophisticated scanning mechanism in the documentation, both end up documented, but only the second one should.

Describe the solution you'd like
Since in the second one stores @plugin hooks, what about renaming it something else? E.g. events.py or plugin_events.py or something else

@nicola-corbellini nicola-corbellini added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Jan 2, 2024
@NJacksonDev
Copy link
Contributor

Hi, happy to work on this. Could you please assign this to me?

@nicola-corbellini
Copy link
Member Author

nicola-corbellini commented Jan 2, 2024

@NJacksonDev done! Let's go with plugin_events.py name please. Thank you!

@NJacksonDev NJacksonDev mentioned this issue Jan 4, 2024
5 tasks
pieroit added a commit that referenced this issue Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants