Ohai uptime plugin hangs in Windows. #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| ## Windows newer versions category here includes server OS starting from Windows Server 2008 ## | ||
| shared_context "WMI class to use to fetch system uptime for newer versions of Windows platform" do |
There was a problem hiding this comment.
can you make the names of the shared context's more brief? that's a lot of words with only one in the middle that is different. It should be easier to tell the difference just looking at them.
|
Done. |
|
👍 |
|
@Aliasgar16 before I merge this can you just toss a sentence or two into the PR description explaining why we'd want to do this? |
Aliasgar16
changed the title
Aliasgar16
changed the title
|
@tas50 I have modified the description of the PR. Let me know your feedback. |
Aliasgar16
changed the title
|
Thanks @Aliasgar16 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ohai uptime plugin hangs in Windows, solution:
Win32_OperatingSystemfor newer versions of Windows.Win32_PerfFormattedData_PerfOS_Systemfor older versions of Windows.WMI class is from where we retrieve the system's uptime for Windows platform.