Network: Add support for parsing multipath routing

[anitazha]

Signed-off-by: Anita Zhang [email protected]

Description

We have some hosts using multipath routing and the network plugin is failing to set any interface information for the interfaces with such multipath configuration. This PR updates check_routing_table() in the network plugin to support multipath routing.

Related Issue

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[anitazha]

Thanks Phil! Updated with your suggestions

[jaymzh]

Code looks good, sorry I missed the lack of v4-test below, but I suspect that's gonna be the most-commonly-used path in the code, so lets just have a test for it as well?

[anitazha]

There was an existing test case for multipath IPv4 but without the extra options on the first line (line 165 of network_spec.rb). The IPv4 test case I just added includes options.

[jaymzh]

Looks great. I'll merge when tests pass. I'm out of town this weekend so feel free to poke me next week if I haven't merged.

[tas50]

@anitazha is this something we'd want to backport to Ohai 16 and 17?

[anitazha]

@tas50 It could be useful to have since any default IPv6 routes with options using multipath just break without it. But I think multipath routing isn't super widely used so most people won't run into it.