Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing bug in the rpm plugin #1719

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Fix parsing bug in the rpm plugin #1719

merged 1 commit into from
Dec 6, 2021

Conversation

davide125
Copy link
Contributor

Signed-off-by: Davide Cavalca [email protected]

Description

The rpm plugin that was added in #1718 had a bug in the parsing logic that caused it to swallow one-line macros when they were immediately followed by another one. This PR fixed that, and adds a few comments to hopefully make the logic easier to understand.

Related Issue

#1718

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@davide125 davide125 requested review from a team as code owners December 2, 2021 16:56
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would clarify things a bit. LMK what you think. Will merge either way. Clearly correct bugfix.

@jaymzh jaymzh merged commit 4108a87 into chef:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants