Add Alibaba cloud plugin #1620
Merged
Add Alibaba cloud plugin #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detects Alibaba on Linux boxes and fetches metadata Signed-off-by: Tim Smith <[email protected]>
This way you get the cloud info when on Alibaba Signed-off-by: Tim Smith <[email protected]>
jaymzh
reviewed
Feb 8, 2021
lib/ohai/mixin/alibaba_metadata.rb
Outdated
Comment on lines
27
to
30
| # As of 2021-02-07 there is only one API release so this removes the | ||
| # API parsing logic in the ec2 metadata mixin. If that changes we | ||
| # may want to merge these two codebases | ||
| # |
There was a problem hiding this comment.
why split them, just to make someone else (probably you) merge them later? It's a versioned API, so it'll very likely get an additional version... why make that painful for us then?
There was a problem hiding this comment.
I need to actually remove that comment. It became clear pretty quickly that the approaches are very different and not something we could merge / make generic.
lamont-granquist
approved these changes
Feb 8, 2021
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects Alibaba on Linux boxes and fetches metadata
Signed-off-by: Tim Smith [email protected]