Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [#1406]: ensure optional_plugins to be array of symbols #1408

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

salzig
Copy link
Contributor

@salzig salzig commented Oct 31, 2019

updated the ohai configuration declaration to ensure that values written to ohai[:optional_plugins] are always an array of symbols.

Related Issue

fixes #1406

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@salzig salzig changed the title fix: ensure optional_plugins to be array of symbols fix [#1406]: ensure optional_plugins to be array of symbols Oct 31, 2019
@salzig salzig force-pushed the fix/ensure_optional_plugins_to_be_symbols branch 2 times, most recently from 99756be to 64f28c9 Compare October 31, 2019 10:26
@salzig salzig force-pushed the fix/ensure_optional_plugins_to_be_symbols branch from 64f28c9 to 61a2616 Compare October 31, 2019 10:29
@salzig
Copy link
Contributor Author

salzig commented Oct 31, 2019

$ asdf local ruby 2.5.5
version 2.5.5 is not installed for ruby

$ asdf local ruby 2.6.3
version 2.6.3 is not installed for ruby

Tests are failing cause the necessary ruby version isn't installed

@salzig
Copy link
Contributor Author

salzig commented Nov 3, 2019

bump, any chance to get this merged? Would help me a lot.

@tas50 tas50 merged commit 61a2616 into chef:master Jan 29, 2020
@tas50
Copy link
Contributor

tas50 commented Jan 29, 2020

@salzig Sorry for the delay. I added a test to ensure that string inputs are converted to symbols and then merged it.

@salzig salzig deleted the fix/ensure_optional_plugins_to_be_symbols branch January 29, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please let optional_plugins accept strings. Or error out
2 participants