[filesystem] Convert rest of unix to fs2 #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymzh
force-pushed
the
finish_fs2_work
branch
from
0e119cc to
23e7f87
Compare
jaymzh
commented
Oct 5, 2018
| context "when 'zfs get' properties are not configured" do | ||
| it "collects all filesystem properties" do | ||
| expect(plugin).to receive(:shell_out) | ||
| context "handles zfs properties" do |
There was a problem hiding this comment.
If someone wants to give me df -Pka and mount output from a Solaris box, I'll write some unittests for that part of the code since whoever wrote this originally never did.
@scotthain - you have access to the internal slowlaris boxes, right?
There was a problem hiding this comment.
@jaymzh here it is in all its glory... https://gist.github.com/scotthain/f03e9fab0e575a137083e0d3f0033a5b
caveats:
- I redacted some username and
servername.chef.internal.dns - Both the solaris 10 and 11 machines are zones running on a single solaris 11 host, so you're going to get some weird zone-specific stuff there.
hopefully this helps, I don't have much in the way of bare raw metal anymore :)
There was a problem hiding this comment.
Thanks, that works. I also need df -na to test that bit too. other tests added.
|
I'll look at the windows tests tomorrow... |
jaymzh
force-pushed
the
finish_fs2_work
branch
2 times, most recently
from
6b62a70 to
78d182c
Compare
tas50
reviewed
Oct 6, 2018
appveyor.yml
Outdated
| @@ -24,7 +24,7 @@ install: | |||
| - bundler --version | |||
|
|
|||
| build_script: | |||
| - bundle install | |||
| - bundle install || build install || bundle install | |||
This PR [almost] finishes the implementing support for the "filesystem2" format for the rest of the platforms that were never converted - everything except Windows which will be in a follow-up PR. Here's some other cleanup along hte way: * Fix the fact that "allow_partial_data" only worked on Linux. Oops. * Add helper for "allow_partial_data" stuff so that "allow_partial_data" support was easy to be consistent about * Always get all ZFS options, no reason not to provide all data * Change the way zfs options are laid out. The existing way separates everything into two hashes that need be correlated by the user and doesn't seem to make much sense. Signed-off-by: Phil Dibowitz <[email protected]>
jaymzh
force-pushed
the
finish_fs2_work
branch
from
35c19a3 to
8a82f74
Compare
jaymzh
changed the title
|
I dropped the Windows stuff from this PR, I'll push that up in another PR. |
4 tasks
jaymzh
added a commit
to jaymzh/ohai
that referenced
this pull request
Oct 6, 2018
[based on top of chef#1266 - will rebase after that is merged] Windows doesn't follow quite the same paradigms as Unix, but there's enough in common that we can still map most things. The tests don't pass here, yet, and I'm not quite sure why. In some test logical_properties is returning an array but I don't see how that's possible. :/ Signed-off-by: Phil Dibowitz <[email protected]>
|
@chef/client-core @chef/client-maintainers - this is ready for review. |
jaymzh
added a commit
to jaymzh/ohai
that referenced
this pull request
Oct 10, 2018
[based on top of chef#1266 - will rebase after that is merged] Windows doesn't follow quite the same paradigms as Unix, but there's enough in common that we can still map most things. The tests don't pass here, yet, and I'm not quite sure why. In some test logical_properties is returning an array but I don't see how that's possible. :/ Signed-off-by: Phil Dibowitz <[email protected]>
jaymzh
added a commit
to jaymzh/ohai
that referenced
this pull request
Oct 10, 2018
[based on top of chef#1266 - will rebase after that is merged] Windows doesn't follow quite the same paradigms as Unix, but there's enough in common that we can still map most things. The tests don't pass here, yet, and I'm not quite sure why. In some test logical_properties is returning an array but I don't see how that's possible. :/ Signed-off-by: Phil Dibowitz <[email protected]>
jaymzh
added a commit
to jaymzh/ohai
that referenced
this pull request
Dec 19, 2018
[based on top of chef#1266 - will rebase after that is merged] Windows doesn't follow quite the same paradigms as Unix, but there's enough in common that we can still map most things. The tests don't pass here, yet, and I'm not quite sure why. In some test logical_properties is returning an array but I don't see how that's possible. :/ Signed-off-by: Phil Dibowitz <[email protected]>
jaymzh
added a commit
to jaymzh/ohai
that referenced
this pull request
Dec 19, 2018
[based on top of chef#1266 - will rebase after that is merged] Windows doesn't follow quite the same paradigms as Unix, but there's enough in common that we can still map most things. The tests don't pass here, yet, and I'm not quite sure why. In some test logical_properties is returning an array but I don't see how that's possible. :/ Signed-off-by: Phil Dibowitz <[email protected]>
tas50
added
Expeditor: Bump Version Minor
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR [almost] finishes the implementing support for the "filesystem2"
format for the rest of the platforms that were never converted -
everything except Windows which will be in a follow-up PR.
Here's some other cleanup along hte way:
support was easy to be consistent about
everything into two hashes that need be correlated by the user and
doesn't seem to make much sense.
Signed-off-by: Phil Dibowitz [email protected]
Check List