Add "EncryptionStatus" to each volume on Windows

[Nimesh-Msys]

• Changes to fetch Encryption Status of a volume
• Fixed cases to handle WMI Exceptions
• Added test cases
• Minor code cleanup
• Fixes MSYS-894

Signed-off-by: Nimesh [email protected]

Description

By using GetConversionStatus method of Win32_EncryptableVolume class, we may fetch encryption status of a volume

Issues Resolved

#1226

Check List

• New functionality includes tests
• All tests pass
• RELEASE_NOTES.md, has been updated if required (not required for bugfixes, required for API changes)
• All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

[kmf]

Cool!

[Nimesh-Msys]

@stuartpreston , I tried few changes in AppVeyor config to connect with required namespace
As the reference states: If you receive the message Interactive mode set then you were able to connect to the namespace
Build log is displaying the expected result still there are failing specs on appveyor.
Could you please let me know your views on this.

[stuartpreston]

@Nimesh-Msys Your approach looks correct and I like where this is going, so I'm I wondering if this is an Appveyor issue with their default build. Thoughts:

1. Have you tried using a Windows Server 2016 builder?
2. The path to the namespace may be case sensitive on some platforms (?) (root vs Root etc?)

[Nimesh-Msys]

@stuartpreston , Thank you for the above points.
I've already checked (2). Path to the namespace is case insensitive. Root\CIMV2 and root\cimv2 both works well.

Tried with option (1): build is failing as:

Build worker image not found: Windows Server 2016

Also tried to build on Windows Server 2012, getting the same error:

The specified namespace name 'Root\CIMV2\Security\MicrosoftVolumeEncryption' is not a valid namespace name or does not exist.

According to some blogs, in case we are facing 'OLE error 80004001', There are chances that WMI is broken, and it needs to be rebuild.

[stuartpreston]

Can you try with Visual Studio 2017 which should have everything required for Windows Server 2016? See https://www.appveyor.com/docs/build-environment/#choosing-image-for-your-builds

[stuartpreston]

FWIW - here's the output of the specs from my Windows10 machine. In case we can't get this working in Appveyor.

C:\projects\chef\ohai [MsysTechnologiesllc-nimesh/MSYS-894_add_encryption_status]> bundle exec rspec .\spec\unit\plugins\windows\filesystem_spec.rb
Run options:
  include {:focus=>true}
  exclude {:requires_root=>true, :unix_only=>true}

All examples were filtered out; ignoring {:focus=>true}

Ohai::System Windows Filesystem Plugin
  WmiLite::Wmi
    When initialized with no arguments
      will create an instance with default namespace ('root/cimv2')
      able to access instance of Win32_LogicalDisk
      unable to access instance of Win32_EncryptableVolume
    When initialized with an argument: (Root\CIMV2)
      will create an instance of namespace
      able to access instance of Win32_LogicalDisk
      unable to access instance of Win32_EncryptableVolume
    When initialized with an argument: (Root\CIMV2\Security\MicrosoftVolumeEncryption)
      will create an instance of namespace
      unable to access instance of Win32_LogicalDisk
      able to access instance of Win32_EncryptableVolume
  #logical_disk_properties
    with no arguments
      raises an error
    with wmi object of root namespace
      collects local disks information in Mash
      mash will contain expected information
    with wmi object of encryption namespace
      raises an error
  #encryptable_volume_properties
    with no arguments
      raises an error
    when Mash is empty
      and wmi object of root namespace
        raises an error
      and wmi object of encryption namespace
        raises an error
    when Mash is pre-filled with logical_disk_properties
      and wmi object of root namespace
        raises an error
      and wmi object of encryption namespace
        collects local disks information in Mash
        mash will contain expected information

Finished in 0.40645 seconds (files took 2.15 seconds to load)
19 examples, 0 failures

C:\projects\chef\ohai [MsysTechnologiesllc-nimesh/MSYS-894_add_encryption_status]> bundle exec ohai filesystem{
  "C:": {
    "kb_size": 511463911,
    "kb_available": 169724002,
    "kb_used": 341739909,
    "percent_used": 66,
    "mount": "C:",
    "fs_type": "ntfs",
    "volume_name": "",
    "encryption_status": "FullyEncrypted"
  }
}
C:\projects\chef\ohai [MsysTechnologiesllc-nimesh/MSYS-894_add_encryption_status]>

[Nimesh-Msys]

Yes, It's working properly on my Win10 machine too. 👍

[stuartpreston]

LGTM, woud like @tas50 to approve for merge

[tas50]

@Nimesh-Msys Thanks for breaking up the plugin and adding tests. This is in a much more maintainable state now.

[Nimesh-Msys]

Thank you :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.