Prefer ipv4 for default_gateway over ipv6 on windows #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nimesh-Msys
changed the title
Nimesh-Msys
force-pushed
the
nimesh/MSYS-875_prefer_ipv4_default_gateway_windows
branch
4 times, most recently
from
d894697 to
34fa857
Compare
Nimesh-Msys
changed the title
rhass
approved these changes
Aug 17, 2018
|
|
||
| # it "Failed example !!!" do | ||
| # expect(plugin.favored_ip).to eq('b') | ||
| # end |
There was a problem hiding this comment.
Unless there is a compelling reason to keep this, we should remove the commented out example.
There was a problem hiding this comment.
Sorry. That was a typo. Removing.
Nimesh-Msys
force-pushed
the
nimesh/MSYS-875_prefer_ipv4_default_gateway_windows
branch
from
34fa857 to
4c825be
Compare
tas50
reviewed
Aug 20, 2018
lib/ohai/plugins/windows/network.rb
Outdated
| @@ -53,6 +53,42 @@ def msft_adapter_data | |||
| data | |||
| end | |||
|
|
|||
| # Returns the interface code in Hexadecimal Format | |||
There was a problem hiding this comment.
YARD format would be helpful here in the future
There was a problem hiding this comment.
I've updated them. Could you please take a look.
Thanks
lamont-granquist
approved these changes
Aug 20, 2018
tas50
suggested changes
Aug 20, 2018
- Minor fix to select default_interface based on the least metric value - Fix to prefer default_fateway in IPV4 Format - DRY-UP to get interface_code - Commented as per YARD format - Added test cases - Fixes: MSYS-875 Signed-off-by: Nimesh <[email protected]>
Nimesh-Msys
force-pushed
the
nimesh/MSYS-875_prefer_ipv4_default_gateway_windows
branch
from
4c825be to
a908f9f
Compare
|
Thanks for the comments @Nimesh-Msys |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nimesh [email protected]
Description
According to previous logic, there was an iteration over all the interfaces and the value of
default_gatewayanddefault_interfacewas getting reset in each loop. Hence the last interface was chosen as default_interface and so its default_gateway.default_gatewaywas selected as the first one out from the list ofdefault_ip_gatewayof an interface, hence there was a possibility that if this list contain IPV6 address at former place, then it was selected.In case of multiple Interfaces, priority for
default_interfaceshould be given to the interface with least metric value. Also, we need to preferIPV4value ofdefault_gatewayoverIPV6Issues Resolved
#746
Check List