Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle uptimes over a year on AIX #1049

Merged
merged 4 commits into from
Sep 1, 2017

Conversation

rmcleod8
Copy link
Contributor

@rmcleod8 rmcleod8 commented Sep 1, 2017

Description

The existing Ohai plugin for returning uptime on AIX machines doesn't account for the year in which the box was booted leading to false positives and negative values

Issues Resolved

Sample of existing issue


Ohai:
--
"uptime_seconds": -4845099,
"uptime": "22 hours 08 minutes 21 seconds",
 
s178 # uptime
09:16AM   up 308 days,  22:10,  4 users,  load average: 7.60, 9.58, 11.85
s178 # who -b
.        system boot Oct 27 11:07

Check List

@rmcleod8 rmcleod8 requested a review from a team September 1, 2017 18:27
@rmcleod8 rmcleod8 force-pushed the aix_uptime_is_wrong_af branch from 4b66b77 to a21e33b Compare September 1, 2017 18:31
richard mcleod added 3 commits September 1, 2017 14:41
@tas50
Copy link
Contributor

tas50 commented Sep 1, 2017

Thanks for including the comments explaining exactly why you were doing things. That's really helpful years later when we try to understand these things.

@tas50 tas50 merged commit ed190dc into chef:master Sep 1, 2017
@adamleff
Copy link
Contributor

adamleff commented Sep 1, 2017

Huge 👍 for the helpful comments, @rmcleod8. Thanks for fixing this issue!

@tas50 tas50 changed the title changing method to gather AIX uptime Properly handle uptimes over a year on AIX Sep 11, 2017
@chef chef locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants