Detect F5 Big-IPs as platform bigip #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're RHEL + a bunch of secret sauce. Put them in the RHEL platform family, detect the platform properly, and parse the platform version so it doesn't get the RHEL platform version instead. Signed-off-by: Tim Smith <[email protected]>
|
angrysauce CI tests |
lamont-granquist
approved these changes
Jul 19, 2017
|
Oh I knew that would blow up. If there's no objections to this PR I'll go fix the specs |
stevendanna
reviewed
Jul 19, 2017
| def bigip_version | ||
| release_contents = File.read("/etc/f5-release") | ||
| release_contents.match(/BIG-IP release (\S*)/)[1] # http://rubular.com/r/O8nlrBVqSb | ||
| rescue NoMethodError, Errno::ENOENT, Errno::EACCES # rescue regex failure, file missing, or permission denied |
There was a problem hiding this comment.
An explanation since it took me a moment: The NoMethodError catches the regex failure because String#match returns nil if there was no match and [] isn't a method on nil.
stevendanna
approved these changes
Jul 19, 2017
Signed-off-by: Tim Smith <[email protected]>
|
Or just 1! :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're RHEL + a bunch of secret sauce. Put them in the RHEL platform family, detect the platform properly, and parse the platform version so it doesn't get the RHEL platform version instead.
Signed-off-by: Tim Smith [email protected]