Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining time parameter to output gcode #9

Closed
drzejkopf opened this issue Nov 23, 2019 · 11 comments
Closed

Add remaining time parameter to output gcode #9

drzejkopf opened this issue Nov 23, 2019 · 11 comments

Comments

@drzejkopf
Copy link

Hi, is there any chance that M73 R parameter (remaining time) support would be added to this plugin? It is now supported by at least 2 firmwares (Prusa Firmware and Marlin 2.0, see MarlinFirmware/Marlin#15549) and I think it would be a cool feature to have it supported, especially when combined with PrintTimeGenius

@cesarvandevelde
Copy link
Owner

Hi drzejkopf. I've spent an evening looking at this, and it seems doable. I got the bare-bones functionality working, but I'll need a couple more days to clean everything up. I'm currently running an older version of Marlin and I'm not too keen on messing with the firmware. Would you be willing to do some beta-testing for this?

@drzejkopf
Copy link
Author

@cesarvandevelde sure I can, I print daily so I can do some testing, and I'm next to printer most time so I can check frequently if everything works fine

@cesarvandevelde
Copy link
Owner

@drzejkopf I've just finished a version that is ready for testing: feature/time_remaining.
To install, you will probably have to uninstall the current version first. After that, you can install the zip file using the "... from an uploaded archive" option inside the OctoPrint plugin manager.

This version includes two new features:

  • Output time left: Outputs the remaining time (in minutes) using the P parameter.
  • Use time estimate: By default, the plugin uses the progress estimate provided by OctoPrint. With this option, progress is calculated using the following formula: progress = time_elapsed / (time_elapsed + estimated_time_remaining). This matches the way PrintTimeGenius works.

Both features can be enabled/disabled in Octoprint settings > Plugins > M73 Progress. I've done some quick test prints, and everything seems to be working correctly on my end. It would be really great if you could do more in-depth testing on your setup!

@drzejkopf
Copy link
Author

@cesarvandevelde I've just installed plugin (removed old and installed new one from package), but settings page is blank, have you got any idea what's going on? (I've got OctoPrint 1.3.12 on OctoPi 0.16.0, RPi 3B+)
obraz

@cesarvandevelde
Copy link
Owner

This may sound silly, but did you try scrolling up? I noticed on my system that the left-hand side and right-hand side scroll together, and that can obscure the two checkboxes...

@drzejkopf
Copy link
Author

@cesarvandevelde Nope, still nothing, I've also rebooted OctoPrint, then rebooted whole RPi and still nothing. I inspected it using "Inspect element" option in Firefox and it seems to be blank too
obraz

@cesarvandevelde
Copy link
Owner

Strange...

  • Can you post your octoprint.log?
  • Can you check the contents of ~/oprint/lib/python2.7/site-packages/octoprint_m73progress/templates?

@drzejkopf
Copy link
Author

I attach log and file which was present in given directory (it's the only file that was there)
files.zip

@cesarvandevelde
Copy link
Owner

The log file does not show any errors, and the template file is correct. I've done an install-from-zip on a blank instance of OctoPrint, and that worked correctly as well... Have you tried clearing your browser cache?

@drzejkopf
Copy link
Author

@cesarvandevelde Hi, I have done ~10 prints with new plugin, everything seems to be working properly. Also, clearing browser cache helped with blank settings page

@cesarvandevelde
Copy link
Owner

The new version has been released. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants