goodbye nautilus #1006
Merged
goodbye nautilus #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes nautilus from our github CI tests. The original plan was to remove nautilus from our test matrix when Ceph Squid was released. However, while Squid is not released yet, it is very very soon. In the meantime, CentOS 7 is now EOL and the container images for nautilus can not be updated. From the Ceph POV nautilus has been long unsupported and they will not be making any changes to the base OS for nautilus images. We have no desire to do workarounds for the EOLing of CentOS7 either. As such we're ending direct support for nautilus a little early but not by much. Note that this is only disabling our testing of nautilus - we're not going to be stripping the build tag from the sources. But we will no longer require new code to to add it either. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Remove nautilus from the make file's "known ceph codenames". This change goes along with the removal of nautilus from the CI as the makefile is really only used by developers/contributors and not by codebases that use go-ceph. Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
added
the
no-API
|
Github branch protection rules referring to nautilus are still present. These need to be manually updated in the gihub ui. |
Closed
ansiwen
approved these changes
Jul 2, 2024
anoopcs9
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes nautilus from our github CI tests and related files.
Fixes: #648
Closes: #1005
The original plan was to remove nautilus from our test matrix when Ceph
Squid was released. However, while Squid is not released yet, it is very
very soon. In the meantime, CentOS 7 is now EOL and the container images
for nautilus can not be updated. From the Ceph POV nautilus has been
long unsupported and they will not be making any changes to the base OS
for nautilus images. We have no desire to do workarounds for the EOLing
of CentOS7 either. As such we're ending direct support for nautilus a
little early but not by much.
Note that this is only disabling our testing of nautilus - we're not
going to be stripping the build tag from the sources. But we will no
longer require new code to to add it either.