Fix create delete test for rebalance logic #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baum
force-pushed
the
create_delete_test_fix
branch
2 times, most recently
from
9df74a6 to
fbe447b
Compare
leonidc
approved these changes
Dec 17, 2024
Signed-off-by: Alexander Indenbaum <[email protected]>
baum
force-pushed
the
create_delete_test_fix
branch
from
fbe447b to
137496f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix create delete test for rebalance logic
In #980, the removal of the failover state transition rendered the test awkward. The initial state and the state described as "failover" became identical, allowing the test to pass even if no monitor action occurred in response to gateway deletions.
Parallelized the check for healthy gateways and their subsystems. Each parallel task first verifies the "failover" number of groups and then confirms the "rebalance" number of group in degraded state.
See #980 (comment)