Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for string peer parameter #901

Closed
gbregman opened this issue Oct 14, 2024 · 0 comments · Fixed by #902
Closed

Allow for string peer parameter #901

gbregman opened this issue Oct 14, 2024 · 0 comments · Fixed by #902
Assignees

Comments

@gbregman
Copy link
Collaborator

In control/grpc.py code we have:

peer = context.peer().split(":", 1)

In some case we simulate the GRPC call ourselves and pass an empty string context instead of the actual object. In these cases we get the error:

ERROR grpc.py:851 (1): Got exception trying to get peer's address
Traceback (most recent call last):
  File "/src/control/grpc.py", line 838, in get_peer_message
    peer = context.peer().split(":", 1)
AttributeError: 'str' object has no attribute 'peer'

We need to check for this case and not display an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant