Proper support for caching helm chart from Artifactory. #5123
Conversation
mergify
bot
added
the
component/deployment
Lirt
force-pushed
the
compatibility/helm-artifactory
branch
from
919b8c1 to
f7374e2
Compare
nixpanic
added
the
ci/skip/multi-arch-build
|
Hi @Lirt , thanks for the PR! This looks like a reasonable change to me, and you explained the details well. There are two problems that the commit checker bot complains about: ✖ header must not be longer than 72 characters, current length is 73 [header-max-length] Can you amend your commit message and force-push the branch again? |
Lirt
force-pushed
the
compatibility/helm-artifactory
branch
2 times, most recently
from
0944d65 to
971a2cd
Compare
|
Hi @nixpanic, apologize for rookie mistakes :-). Updated message+body and gpg verification of commit. |
No problem, thanks for the update! Some of the automated checks are rather strict, these things happen to all of us 😄 |
|
@Mergifyio rebase |
Currently helm index configures URLs to charts with relative path (see https://ceph.github.io/csi-charts/index.yaml). Artifactory contains support for virtual repositories. Virtual repositories are able to cache remote repositories and provide offline access to those repositories. In order for this to work correctly, charts must specify absolute base URL to artifacts. This commit adds this base URL using argument for helm index command. URL with previous approach: ```yaml urls: - cephfs/ceph-csi-cephfs-3.13.0.tgz ``` URL with current approach (my personal "lirt" repo was used to test this, the MR specifies correct "ceph" path) ```yaml urls: - https://lirt.github.io/csi-charts/cephfs/ceph-csi-cephfs-3.13.0.tgz ``` Signed-off-by: Ondrej Vasko <[email protected]>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
compatibility/helm-artifactory
branch
from
971a2cd to
b0f869e
Compare
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 78d13b5 |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
Currently helm index of ceph helm repository configures URLs to charts with relative path (see https://ceph.github.io/csi-charts/index.yaml).
Artifactory contains support for virtual repositories. Virtual repositories are able to cache remote repositories and provide offline access to those repositories.
In order for this to work correctly, charts must specify absolute base URL to artifacts.
This commit adds this base URL using argument for helm index command.
URL with previous approach:
URL with current approach (my personal "lirt" repo was used to test this, the MR specifies correct "ceph" path)
Is there anything that requires special attention
This change is backwards compatible.
You can try following commands that suggest the path is the same as previously and work with original repo and updated repo as well. Of course the MR specifies
ceph.prefix.Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.