rbd: return GRPC error from GRPC method #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
added
component/rbd
nixpanic
previously approved these changes
Oct 18, 2022
|
Lets try to get #3439 merged first, CI has been really busy with that for a while... |
Madhu-1
force-pushed
the
fix-grpc-error-message
branch
from
e7c9731 to
52b97a6
Compare
mergify
bot
dismissed
nixpanic’s stale review
Pull request has been modified.
|
Removed DNM as all the PR in pool are merged, @nixpanic @yati1998 @Rakshith-R PTAL |
|
@Mergifyio rebase |
GRPC methods should only return GRPC errors if any error occurs. Signed-off-by: Madhu Rajanna <[email protected]>
✅ Branch has been successfully rebased |
leseb
force-pushed
the
fix-grpc-error-message
branch
from
52b97a6 to
1337153
Compare
nixpanic
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRPC methods should only return GRPC errors if any error occurs.
Signed-off-by: Madhu Rajanna [email protected]