Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: return success if metadata operation not supported #3348

Merged
merged 1 commit into from
Aug 29, 2022
Merged

cephfs: return success if metadata operation not supported #3348

merged 1 commit into from
Aug 29, 2022

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Aug 29, 2022

If the ceph cluster is of the older version and does not support metadata operation, Instead of failing, the request returns the success if metadata operation is not supported.

fixes #3347

Signed-off-by: Madhu Rajanna [email protected]

@Madhu-1 Madhu-1 requested review from pkalever and a team August 29, 2022 05:35
@mergify mergify bot added the component/cephfs Issues related to CephFS label Aug 29, 2022
Rakshith-R
Rakshith-R reviewed Aug 29, 2022
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a warning log at line 47 ?
when it is found that the cluster does not support having metadata.

Other than the above suggestion, the change looks good to me.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 29, 2022

Add a warning log at line 47 ? when it is found that the cluster does not support having metadata.

Other than the above suggestion, the change looks good to me.

We don't log anything in metadata.go it's too much change to do it. I think its okay to leave the logging as we don't log anything if its an unsupported operations (in previous releases)

@Madhu-1 Madhu-1 requested a review from Rakshith-R August 29, 2022 07:07
Rakshith-R
Rakshith-R approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rakshith-R
Copy link
Contributor

let's backport it too?

@Madhu-1 Madhu-1 added the ci/retry/e2e Label to retry e2e retesting on approved PR's label Aug 29, 2022
pkalever
pkalever approved these changes Aug 29, 2022
View reviewed changes
Copy link

@pkalever pkalever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.24

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.24" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/k8s-e2e-external-storage/1.24

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/k8s-e2e-external-storage/1.24" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.24

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.24" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@Rakshith-R
Copy link
Contributor

@Mergifyio rebase

@Madhu-1 @mergify
cephfs: return success if metadata operation not supported
31e9b2a 
If the ceph cluster is of older version and doesnot
support metadata operation, Instead of failing
the request return the success if metadata
operation is not supported.

fixes ceph#3347

Signed-off-by: Madhu Rajanna <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

rebase

✅ Branch has been successfully rebased

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.22

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/k8s-e2e-external-storage/1.22

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/k8s-e2e-external-storage/1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/upgrade-tests-cephfs" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.24

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e-helm/k8s-1.24" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.23

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.23" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.22

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.24

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e-helm/k8s-1.24" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.22

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@mergify mergify bot merged commit 038462f into ceph:devel Aug 29, 2022
@mergify mergify bot mentioned this pull request Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@pkalever pkalever pkalever approved these changes

@yati1998 yati1998 yati1998 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees
No one assigned
Labels
ci/retry/e2e Label to retry e2e retesting on approved PR's component/cephfs Issues related to CephFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API call not implemented server-side: No handler found for 'fs subvolume metadata set' in ceph 15.2.17
6 participants
@Madhu-1 @Rakshith-R @ceph-csi-bot @nixpanic @pkalever @yati1998