rbd: fix bug in kmip kms Decrypt function & improve error msg #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in kmip kms Decrypt function, where emd.DEK was fed in a Nonce instead of emd.Nonce by mistake. Signed-off-by: Rakshith R <[email protected]>
This commit uses %q instead %v in error messages and adds result reason and message in kmip verifyresponse(). Signed-off-by: Rakshith R <[email protected]>
mergify
bot
added
component/rbd
Madhu-1
approved these changes
Aug 24, 2022
|
skipping e2e i dont think we have e2e for EMIP. |
|
/retest all |
humblec
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rbd: fix bug in kmip kms Decrypt function
This commit fixes a bug in kmip kms Decrypt
function, where emd.DEK was fed in a Nonce
instead of emd.Nonce by mistake.
Signed-off-by: Rakshith R [email protected]
rbd: improve kmip verifyResponse() error message
This commit uses %q instead %v in error messages
and adds result reason and message in kmip
verifyresponse().
Signed-off-by: Rakshith R [email protected]
I had found this bug in testing and fixed it in a testing branch, missed to push to the branch linked to the pr.
🤦 😞