Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd/cleanup: maybe doSnapshotClone() should return an rbdSnapshot #5164

Open
nixpanic opened this issue Feb 19, 2025 · 0 comments
Open

rbd/cleanup: maybe doSnapshotClone() should return an rbdSnapshot #5164

nixpanic opened this issue Feb 19, 2025 · 0 comments

Comments

@nixpanic
Copy link
Member

rbdVolume does not have a SourceVolumeID, it is only part of rbdSnapshot. Maybe doSnapshotClone() should return an rbdSnapshot, or something else in the flow needs to be adjusted. I know that this isn't very clean, hence the FIXME comment.

Originally posted by @nixpanic in #5151 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nixpanic