Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: ceph-csi-operator deployment support #4947

Draft
wants to merge 5 commits into
base: devel
Choose a base branch
from
Draft

e2e: ceph-csi-operator deployment support #4947

wants to merge 5 commits into from
+417 −118

Conversation

iPraveenParihar
Copy link
Contributor

@iPraveenParihar iPraveenParihar commented Nov 7, 2024 •
edited by nixpanic
Loading

Describe what this PR does

This PR supports running e2e tests against a ceph-csi deployment via ceph-csi-operator.

Includes -

  • scripts/deploy-ceph-csi-operator.sh to deploy ceph-csi via operator.
  • e2e/operator.go includes util methods for ceph-csi-operator.
  • changes to handle delete/update of ceph-csi pods.

Is there anything that requires special attention

Do you have any questions?

Is the change backward compatible?

Are there concerns around backward compatibility?

Provide any external context for the change, if any.

For example:

  • Kubernetes links that explain why the change is required
  • CSI spec related changes/catch-up that necessitates this patch
  • golang related practices that necessitates this change

Related issues

Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.

Depends-on: #4931
Fixes: #4856

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar iPraveenParihar added the component/testing Additional test cases or CI work label Nov 7, 2024
@iPraveenParihar iPraveenParihar self-assigned this Nov 7, 2024
@iPraveenParihar iPraveenParihar mentioned this pull request Nov 7, 2024
Open
@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from 306a93b to 0013f7a Compare November 7, 2024 06:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 8, 2025
@iPraveenParihar iPraveenParihar mentioned this pull request Jan 21, 2025
Merged
6 tasks
@github-actions GitHub Actions
Copy link

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

@github-actions github-actions bot closed this Jan 23, 2025
@nixpanic
Copy link
Member

/test ci/centos/mini-e2e-operator/k8s-1.31

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e-operator/k8s-1.31

This failed to pull the quay.io/cephcsi/ceph-csi-operator: (without tag?) from the CI mirror. You will need to add the container-image to images.txt and wait until tomorrow to try again.

@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from 0013f7a to 2e8be35 Compare February 13, 2025 09:54
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar iPraveenParihar mentioned this pull request Feb 13, 2025
Merged
6 tasks
@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from 2e8be35 to 91eb086 Compare February 17, 2025 05:12
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from 91eb086 to a17041e Compare February 17, 2025 06:48
@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from a17041e to 0d9a18b Compare February 24, 2025 05:13
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch 3 times, most recently from 95811d1 to a00f47f Compare February 24, 2025 09:54
@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch 2 times, most recently from 8d33883 to ac82bbe Compare February 24, 2025 12:26
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from ac82bbe to ad5f270 Compare February 24, 2025 17:00
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from ad5f270 to 78229a0 Compare February 25, 2025 10:14
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from 78229a0 to 234b043 Compare February 25, 2025 10:37
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from 234b043 to c67a6b7 Compare February 25, 2025 11:06
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch 2 times, most recently from 5924781 to 42f6446 Compare February 26, 2025 09:39
@iPraveenParihar
ci: script to deploy ceph-csi via ceph-csi-operator
5250001 
Signed-off-by: Praveen M <[email protected]>
@iPraveenParihar
e2e: add operatorDeployment flag
310a00f 
This commit adds `operatorDeployment` flag, defaults to false.
Set this to true for running test on ceph-csi deployment via
operator.

Signed-off-by: Praveen M <[email protected]>
@iPraveenParihar
e2e: unset readAffinity cli option
39722fd 
Signed-off-by: Praveen M <[email protected]>
@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from 42f6446 to 6e31c6a Compare February 26, 2025 09:47
@iPraveenParihar
e2e: handle ceph-csi-operator deployment changes
aa8ea53 
This commits adds e2e/operator.go containing utility
methods specific to the operator.

Signed-off-by: Praveen M <[email protected]>
@iPraveenParihar
e2e: hack commit
62b0cda 
Signed-off-by: Praveen M <[email protected]>
@iPraveenParihar iPraveenParihar force-pushed the e2e/ceph-csi-operator-deployment-support branch from 6e31c6a to 62b0cda Compare February 26, 2025 09:51
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-operator/k8s-1.31

@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.31

@iPraveenParihar
Copy link
Contributor Author

operator CI failed - logs

  • CephFS failed at fuse recovery test as the mount-info volumeMount is not present (raised a PR on ceph-csi-operator)
  • NFS: failed subvolume count 0 not matching expected count 1 (🤔 it passed on my machine.. probably updated csi-config-map didn't take in effect when test ran.)

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e-operator/k8s-1.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic Awaiting requested review from nixpanic

At least 2 approving reviews are required to merge this pull request.

Assignees

@iPraveenParihar iPraveenParihar

Labels
component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run e2e with ceph-csi deployed via ceph-csi-operator
2 participants
@iPraveenParihar @nixpanic