fix csi rbac in kustomize #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note:- This still needs some changes to work for both downstream and upstream. putting this one hold for now |
Madhu-1
force-pushed
the
fix-csi-rbac
branch
2 times, most recently
from
40ed3f3 to
b4788f9
Compare
nb-ohad
requested changes
Aug 8, 2024
Madhu-1
force-pushed
the
fix-csi-rbac
branch
6 times, most recently
from
a77b19c to
2293d74
Compare
Madhu-1
force-pushed
the
fix-csi-rbac
branch
2 times, most recently
from
4ee14ad to
9072e84
Compare
Madhu-1
commented
Aug 8, 2024
nb-ohad
requested changes
Aug 8, 2024
Madhu-1
force-pushed
the
fix-csi-rbac
branch
3 times, most recently
from
16f183a to
06ce496
Compare
Moving the csi RBAC to a new folder which can be build and applied differently and we dont need to have same namePrefix and namespacePrefix for these files as this is not required to be deployed in the same namespace as the operator. Signed-off-by: Madhu Rajanna <[email protected]>
nb-ohad
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the csi RBAC to a new folder can be built and applied differently and we dont need to have the same namePrefix and namespacePrefix for these files as this is not required to be deployed in the same namespace as the operator.
fixes: #87
fixes: #106