remove controller runtime dependency #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we have seen the issues in other project where api is having controller runtime as dependency eventhrouh the main project importing the operator doesnt have the dependency on controller runtime directly now they need to wait for it to update to other kubernetes version as well. Signed-off-by: Madhu Rajanna <[email protected]>
|
@leelavg ^^ |
|
If all agree on this one, am going to test it later |
|
nb-ohad
approved these changes
Aug 7, 2024
|
I would suggest having a different approach here. We can create our own interface on top of Register and use it inside the API Package. The can be considered for the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
we have seen the issues in other projects where API has controller runtime as a dependency though the main project importing the operator doesn't have the dependency on controller runtime directly now they need to wait for it to update to other kubernetes versions as well.
#94 (comment)