checkcerts.py: actually fix "send email" #767
Merged
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argparse can't do a nargs="*" optional arg *and* check for its presence; add a separate arg -E to send the email, and keep -e as an optional list of addressees. Also add the full path and host where checkcerts.py is running. Signed-off-by: Dan Mick <[email protected]>
djgalloway
approved these changes
Feb 26, 2025
|
Tested? Working? |
|
yes, to [email protected] and selected individuals (the default in the python). Perhaps we should have a less-rh-centric team alias instead, but I got emails about [14].chacra.ceph.com this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argparse can't do a nargs="*" optional arg and check for its presence; add a separate arg -E to send the email, and keep -e as an optional list of addressees.
Also add the full path and host where checkcerts.py is running.