Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunService step connection is never disconnected, leading to memory leak when vide is required again in a new execution environment #45

Open
TrippTrapp84 opened this issue Jan 11, 2025 · 2 comments

Comments

@TrippTrapp84
Copy link

Culprit Code

This connection is never disconnected unless you manually setup a runservice connection and invoke Vide.step yourself. This would normally be fine in a live game but in environments like plugins (ui-labs is where I encountered this issue) this leads to the runservice connection never being cleaned and becoming a memory leak.

I'll be filing an issue with ui-labs to get this case fixed but it might be worth adding some way to destroy all the connections setup by a running vide instance.

@jisham318
Copy link

@TrippTrapp84
Copy link
Author

Have you tried cleanup()?

That's not the issue, this event is never connected to a scope or any cleanup behavior outside of calling .step yourself, which should not be required because it forces plugins like ui-labs to call .step, which removes the ability for the sandboxed story environments to call .step themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants