-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide query option to respect accessibility #970
Comments
@thymikee @AugustinLF any thoughts on the above? |
I'm in favor. However, I'd see this as a temporary solution until we're sure about the way it works is in a perfect sync with how react-native treats those accessibility traits. We should make it explicit from the beginning when documenting the feature. |
As in all other cases like queries we are doing our best but only imperfectly simulate RN runtime environment. RTL for web can rely on JS DOM to have a very real-like environment so it has a much simpler work in that regard. |
The path you outline sounds worth pursuing IMO. |
I would also love to have that feature! @mdjastrzebski Can I help finishing the implementation? |
@MattAgn please do! 💯 This would be a very useful feature to have in RNTL! |
Describe the Feature
This issue is based on #787 PR. That PR is stale but idea seems worth pursuing.
Currently all queries ignored accessibility ignored the fact that certain element, e.g. screen or modal is present in component tree but not really visible to the user.
This problem largely does not exist in web React world as previous screens are removed from component tree, except modals, but it is relevant in React Native world. We even suggest some work arounds for it with
within
function.Possible Implementations
respectAccessibility
query options for all queries. This query options would be common to all query verbs (getBy
, etc) and predicates (byText
, etc).accessibilityElementsHidden
,importantForAccessibility
,accessibilityViewIsModal
,style={{ display: 'none' }}
, etcRelated Issues
The text was updated successfully, but these errors were encountered: