Image quality

[Tolriq]

Me again :) with latest snapshot.

I have image quality problem with big images but does not happens when using ARGB8888

        Glide.with(YatseApplication.getInstance())
                .load(DisplayHelper.getGlideImageRequest(buffer))
                .centerCrop()
                .placeholder(mDefaultImageResource)
                .error(mDefaultErrorResource)
                .crossFade(250)
                .into((ImageView) view.getTag(imageViewId));

As you can see if you zoom the image (but very visible on the device) the fanart images have horrible vertical bars all over and looks bad :(

The images in cache that I return with a simple new FileInputStream(cachedFile); is joined too so you can see the source size and that the source image is artifact free.

[Tolriq]

@sjudd I posted without edit to open discussion but the problem is caused by e9cfd2d I have reverted locally it and have no more problems even with ARG 565.

I remember that I had to remove the inDither in my own code to avoid such problems.

No idea about the paint flags as I did not used that before.

[sjudd]

Interesting find. Everything I could find about inDither indicates it is in fact the right thing to do when decoding RGB_565 images. It's supposed to add noise to break up banding (ironically).

Did you revert that entire commit, or just inDither? ANTI_ALIAS should also be totally unnecessary, I can't imagine that would have an affect...

[Tolriq]

I reverted the whole commit, but I can test the flags if you want, I have just no idea how they are used and the impact :)

[sjudd]

If you can confirm that just the flags change is fine, then we can go ahead and revert the inDither change.

[Tolriq]

Seems comment was lost :( No visual impact with the FLAG change in the previous PR, on inDither degrade image quality.

But only tested on Android 5.0 and 5.1