Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target.SIZE_ORIGINAL is ignored #333

Closed
eavsievich opened this issue Feb 8, 2015 · 1 comment
Closed

Target.SIZE_ORIGINAL is ignored #333

eavsievich opened this issue Feb 8, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@eavsievich
Copy link

I'm trying to load an original image into ImageView with code like this:

Glide.with(context).load(url)
        .dontTransform();
        .diskCacheStrategy(DiskCacheStrategy.SOURCE);
        .override(Target.SIZE_ORIGINAL, Target.SIZE_ORIGINAL)
        .into(imageView);

But it looks like .override(Target.SIZE_ORIGINAL, Target.SIZE_ORIGINAL) line is always ignored here https://github.com/bumptech/glide/blob/master/library/src/main/java/com/bumptech/glide/request/GenericRequest.java#L258

@eavsievich eavsievich changed the title Target.SIZE_ORIGINAL ignored Target.SIZE_ORIGINAL is ignored Feb 8, 2015
@sjudd sjudd added this to the 3.5.2 milestone Feb 8, 2015
@sjudd sjudd added the bug label Feb 8, 2015
@sjudd sjudd self-assigned this Feb 8, 2015
@sjudd
Copy link
Collaborator

sjudd commented Feb 8, 2015

Looks like you're correct, thanks for the report.

As a work around you can override getSize() (add a subclass with an optional constructor?) in GlideDrawableImageViewTarget and pass in a new Target instead of just the view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants