Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition customization via GlideModule #2182

Closed
FrancoisBlavoet opened this issue Jul 27, 2017 · 1 comment
Closed

Transition customization via GlideModule #2182

FrancoisBlavoet opened this issue Jul 27, 2017 · 1 comment

Comments

@FrancoisBlavoet
Copy link
Contributor

Glide Version: 4.0 RC1
Device/Android Version: Any

Issue details / Repro steps / Use case background: for rich content apps, crossfade is the default and I would like to be able to configure Glide through @GlideModule in order to provide a default transition used when the image does not come from the memory cache.

@sjudd in #1942 you mentioned issues tied to crossfade. Could you expand on this please ?

How would you feel about such a default option, just like we can have default RequestOptions ?

@FrancoisBlavoet FrancoisBlavoet changed the title crossfade by default configuration Transition customization via GlideModule Jul 27, 2017
@sjudd
Copy link
Collaborator

sjudd commented Aug 4, 2017

I tried to find the issues (there have been a number) related to crossfade but GitHub's search isn't the greatest.

My recollection is:

  1. The cross fade shows the placeholder under the full image if the full image is transparent
  2. The cross fade doesn't handle significant differences in sizes between the placeholder and full image, sometimes resulting in the full image being sized incorrectly.

I have no problems with adding a default set of options for transitions just like we have with RequestOptions, it's a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants