-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate URL apis in favor of GlideUrl #176
Comments
My two cents:
NB: I'm also lost in this world of |
Ugh I closed the wrong issue from that commit. Yeah I think @deprecated is sufficient. The goal here is to emphasize that it's a performance problem to obtain and use URLs directly because constructing a URL, URL#equals and URL#hashcode all perform network operations. The GlideUrl class largely mitigates this, but can't do anything about the constructor jank. Ugh yes URL vs URI vs Uri in particular is frustrating, particularly because URL looks like exactly what you want if you're trying to do http/https, but in fact is usually not what you want unless you're actually trying to perform a network request. |
The URL class has a number of problems, we shouldn't be encouraging people to use it. Using strings or just GlideUrl directly is substantially more performant.
The text was updated successfully, but these errors were encountered: