diff --git a/build.gradle b/build.gradle index c728908adc..0a8438f071 100644 --- a/build.gradle +++ b/build.gradle @@ -17,7 +17,6 @@ buildscript { classpath "net.ltgt.gradle:gradle-errorprone-plugin:${ERROR_PRONE_PLUGIN_VERSION}" } classpath "se.bjurr.violations:violations-gradle-plugin:${VIOLATIONS_PLUGIN_VERSION}" - classpath "com.diffplug.spotless:spotless-plugin-gradle:5.11.0" classpath "androidx.benchmark:benchmark-gradle-plugin:${ANDROID_X_BENCHMARK_VERSION}" } } @@ -93,23 +92,6 @@ subprojects { project -> duplicatesStrategy = DuplicatesStrategy.FAIL } - def isDisallowedProject = - project.name in ["third_party", "gif_decoder", "gif_encoder", "disklrucache", "glide"] - if (!isDisallowedProject) { - apply plugin: "com.diffplug.spotless" - - spotless { - java { - target fileTree('.') { - include '**/*.java' - exclude '**/resources/**' - exclude '**/build/**' - } - googleJavaFormat() - } - } - } - apply plugin: 'checkstyle' checkstyle { diff --git a/library/src/main/java/com/bumptech/glide/Glide.java b/library/src/main/java/com/bumptech/glide/Glide.java index e8cbe5bd6d..66a0b0ac69 100644 --- a/library/src/main/java/com/bumptech/glide/Glide.java +++ b/library/src/main/java/com/bumptech/glide/Glide.java @@ -379,7 +379,9 @@ public ArrayPool getArrayPool() { return arrayPool; } - /** @return The context associated with this instance. */ + /** + * @return The context associated with this instance. + */ @NonNull public Context getContext() { return glideContext.getBaseContext(); diff --git a/library/src/main/java/com/bumptech/glide/load/engine/cache/DiskLruCacheWrapper.java b/library/src/main/java/com/bumptech/glide/load/engine/cache/DiskLruCacheWrapper.java index 516bee1f0c..fbabb0cb2a 100644 --- a/library/src/main/java/com/bumptech/glide/load/engine/cache/DiskLruCacheWrapper.java +++ b/library/src/main/java/com/bumptech/glide/load/engine/cache/DiskLruCacheWrapper.java @@ -63,7 +63,9 @@ public static DiskCache create(File directory, long maxSize) { return new DiskLruCacheWrapper(directory, maxSize); } - /** @deprecated Do not extend this class. */ + /** + * @deprecated Do not extend this class. + */ @Deprecated // Deprecated public API. @SuppressWarnings({"WeakerAccess", "DeprecatedIsStillUsed"}) diff --git a/library/src/main/java/com/bumptech/glide/load/engine/executor/GlideExecutor.java b/library/src/main/java/com/bumptech/glide/load/engine/executor/GlideExecutor.java index 85fd4e4eaa..8c659daa44 100644 --- a/library/src/main/java/com/bumptech/glide/load/engine/executor/GlideExecutor.java +++ b/library/src/main/java/com/bumptech/glide/load/engine/executor/GlideExecutor.java @@ -94,7 +94,9 @@ public static GlideExecutor newDiskCacheExecutor( return newDiskCacheBuilder().setUncaughtThrowableStrategy(uncaughtThrowableStrategy).build(); } - /** @deprecated Use {@link #newDiskCacheBuilder()} instead. */ + /** + * @deprecated Use {@link #newDiskCacheBuilder()} instead. + */ // Public API. @SuppressWarnings("WeakerAccess") @Deprecated @@ -127,7 +129,9 @@ public static GlideExecutor newSourceExecutor() { return newSourceBuilder().build(); } - /** @deprecated Use {@link #newSourceBuilder()} instead. */ + /** + * @deprecated Use {@link #newSourceBuilder()} instead. + */ // Public API. @SuppressWarnings("unused") @Deprecated @@ -136,7 +140,9 @@ public static GlideExecutor newSourceExecutor( return newSourceBuilder().setUncaughtThrowableStrategy(uncaughtThrowableStrategy).build(); } - /** @deprecated Use {@link #newSourceBuilder()} instead. */ + /** + * @deprecated Use {@link #newSourceBuilder()} instead. + */ // Public API. @SuppressWarnings("WeakerAccess") @Deprecated @@ -202,7 +208,9 @@ public static GlideExecutor newAnimationExecutor() { return newAnimationBuilder().build(); } - /** @deprecated Use {@link #newAnimationBuilder()} instead. */ + /** + * @deprecated Use {@link #newAnimationBuilder()} instead. + */ // Public API. @SuppressWarnings("WeakerAccess") @Deprecated diff --git a/library/src/main/java/com/bumptech/glide/load/model/UnitModelLoader.java b/library/src/main/java/com/bumptech/glide/load/model/UnitModelLoader.java index 043241d068..8861be5b46 100644 --- a/library/src/main/java/com/bumptech/glide/load/model/UnitModelLoader.java +++ b/library/src/main/java/com/bumptech/glide/load/model/UnitModelLoader.java @@ -22,7 +22,9 @@ public static UnitModelLoader getInstance() { return (UnitModelLoader) INSTANCE; } - /** @deprecated Use {@link #getInstance()} instead. */ + /** + * @deprecated Use {@link #getInstance()} instead. + */ // Need constructor to document deprecation, will be removed, when constructor is privatized. @SuppressWarnings({"PMD.UnnecessaryConstructor", "DeprecatedIsStillUsed"}) @Deprecated @@ -95,7 +97,9 @@ public static Factory getInstance() { return (Factory) FACTORY; } - /** @deprecated Use {@link #getInstance()} instead. */ + /** + * @deprecated Use {@link #getInstance()} instead. + */ // Need constructor to document deprecation, will be removed, when constructor is privatized. @SuppressWarnings("PMD.UnnecessaryConstructor") @Deprecated diff --git a/library/src/main/java/com/bumptech/glide/load/resource/bitmap/BitmapEncoder.java b/library/src/main/java/com/bumptech/glide/load/resource/bitmap/BitmapEncoder.java index 4f948c28f6..5117909107 100644 --- a/library/src/main/java/com/bumptech/glide/load/resource/bitmap/BitmapEncoder.java +++ b/library/src/main/java/com/bumptech/glide/load/resource/bitmap/BitmapEncoder.java @@ -56,7 +56,9 @@ public BitmapEncoder(@NonNull ArrayPool arrayPool) { this.arrayPool = arrayPool; } - /** @deprecated Use {@link #BitmapEncoder(ArrayPool)} instead. */ + /** + * @deprecated Use {@link #BitmapEncoder(ArrayPool)} instead. + */ @Deprecated public BitmapEncoder() { arrayPool = null; diff --git a/library/src/main/java/com/bumptech/glide/load/resource/transcode/BitmapDrawableTranscoder.java b/library/src/main/java/com/bumptech/glide/load/resource/transcode/BitmapDrawableTranscoder.java index c4abeed729..245c2e2a71 100644 --- a/library/src/main/java/com/bumptech/glide/load/resource/transcode/BitmapDrawableTranscoder.java +++ b/library/src/main/java/com/bumptech/glide/load/resource/transcode/BitmapDrawableTranscoder.java @@ -25,7 +25,9 @@ public BitmapDrawableTranscoder(@NonNull Context context) { this(context.getResources()); } - /** @deprecated Use {@link #BitmapDrawableTranscoder(Resources)}, {@code bitmapPool} is unused. */ + /** + * @deprecated Use {@link #BitmapDrawableTranscoder(Resources)}, {@code bitmapPool} is unused. + */ @Deprecated public BitmapDrawableTranscoder( @NonNull Resources resources, @SuppressWarnings("unused") BitmapPool bitmapPool) { diff --git a/library/src/main/java/com/bumptech/glide/request/target/BitmapImageViewTarget.java b/library/src/main/java/com/bumptech/glide/request/target/BitmapImageViewTarget.java index 03b7b5fb23..386a6a1cf7 100644 --- a/library/src/main/java/com/bumptech/glide/request/target/BitmapImageViewTarget.java +++ b/library/src/main/java/com/bumptech/glide/request/target/BitmapImageViewTarget.java @@ -14,7 +14,9 @@ public BitmapImageViewTarget(ImageView view) { super(view); } - /** @deprecated Use {@link #waitForLayout()} instead. */ + /** + * @deprecated Use {@link #waitForLayout()} instead. + */ // Public API. @SuppressWarnings({"unused", "deprecation"}) @Deprecated diff --git a/library/src/main/java/com/bumptech/glide/request/target/BitmapThumbnailImageViewTarget.java b/library/src/main/java/com/bumptech/glide/request/target/BitmapThumbnailImageViewTarget.java index 683367eb5a..90b03a62fb 100644 --- a/library/src/main/java/com/bumptech/glide/request/target/BitmapThumbnailImageViewTarget.java +++ b/library/src/main/java/com/bumptech/glide/request/target/BitmapThumbnailImageViewTarget.java @@ -15,7 +15,9 @@ public BitmapThumbnailImageViewTarget(ImageView view) { super(view); } - /** @deprecated Use {@link #waitForLayout()} instead. */ + /** + * @deprecated Use {@link #waitForLayout()} instead. + */ @SuppressWarnings("deprecation") @Deprecated public BitmapThumbnailImageViewTarget(ImageView view, boolean waitForLayout) { diff --git a/library/src/main/java/com/bumptech/glide/request/target/DrawableImageViewTarget.java b/library/src/main/java/com/bumptech/glide/request/target/DrawableImageViewTarget.java index e11b46a05f..b27c59b429 100644 --- a/library/src/main/java/com/bumptech/glide/request/target/DrawableImageViewTarget.java +++ b/library/src/main/java/com/bumptech/glide/request/target/DrawableImageViewTarget.java @@ -11,7 +11,9 @@ public DrawableImageViewTarget(ImageView view) { super(view); } - /** @deprecated Use {@link #waitForLayout()} instead. */ + /** + * @deprecated Use {@link #waitForLayout()} instead. + */ // Public API. @SuppressWarnings({"unused", "deprecation"}) @Deprecated diff --git a/library/src/main/java/com/bumptech/glide/request/target/DrawableThumbnailImageViewTarget.java b/library/src/main/java/com/bumptech/glide/request/target/DrawableThumbnailImageViewTarget.java index 41951dcc91..40ff2dad43 100644 --- a/library/src/main/java/com/bumptech/glide/request/target/DrawableThumbnailImageViewTarget.java +++ b/library/src/main/java/com/bumptech/glide/request/target/DrawableThumbnailImageViewTarget.java @@ -13,7 +13,9 @@ public DrawableThumbnailImageViewTarget(ImageView view) { super(view); } - /** @deprecated Use {@link #waitForLayout()} instead. */ + /** + * @deprecated Use {@link #waitForLayout()} instead. + */ @Deprecated @SuppressWarnings("deprecation") public DrawableThumbnailImageViewTarget(ImageView view, boolean waitForLayout) { diff --git a/library/src/main/java/com/bumptech/glide/request/target/ImageViewTarget.java b/library/src/main/java/com/bumptech/glide/request/target/ImageViewTarget.java index ce53193f77..f5f15abab9 100644 --- a/library/src/main/java/com/bumptech/glide/request/target/ImageViewTarget.java +++ b/library/src/main/java/com/bumptech/glide/request/target/ImageViewTarget.java @@ -25,7 +25,9 @@ public ImageViewTarget(ImageView view) { super(view); } - /** @deprecated Use {@link #waitForLayout()} instead. */ + /** + * @deprecated Use {@link #waitForLayout()} instead. + */ @SuppressWarnings({"deprecation"}) @Deprecated public ImageViewTarget(ImageView view, boolean waitForLayout) { diff --git a/library/src/main/java/com/bumptech/glide/request/target/ThumbnailImageViewTarget.java b/library/src/main/java/com/bumptech/glide/request/target/ThumbnailImageViewTarget.java index d8b2689ead..f7b208a58b 100644 --- a/library/src/main/java/com/bumptech/glide/request/target/ThumbnailImageViewTarget.java +++ b/library/src/main/java/com/bumptech/glide/request/target/ThumbnailImageViewTarget.java @@ -27,7 +27,9 @@ public ThumbnailImageViewTarget(ImageView view) { super(view); } - /** @deprecated Use {@link #waitForLayout()} insetad. */ + /** + * @deprecated Use {@link #waitForLayout()} insetad. + */ @Deprecated @SuppressWarnings({"deprecation"}) public ThumbnailImageViewTarget(ImageView view, boolean waitForLayout) { diff --git a/library/src/main/java/com/bumptech/glide/request/transition/DrawableCrossFadeFactory.java b/library/src/main/java/com/bumptech/glide/request/transition/DrawableCrossFadeFactory.java index 58cf57d42d..eeddb75fd7 100644 --- a/library/src/main/java/com/bumptech/glide/request/transition/DrawableCrossFadeFactory.java +++ b/library/src/main/java/com/bumptech/glide/request/transition/DrawableCrossFadeFactory.java @@ -50,7 +50,9 @@ public Builder() { this(DEFAULT_DURATION_MS); } - /** @param durationMillis The duration of the cross fade animation in milliseconds. */ + /** + * @param durationMillis The duration of the cross fade animation in milliseconds. + */ public Builder(int durationMillis) { this.durationMillis = durationMillis; } diff --git a/mocks/src/main/java/com/bumptech/glide/load/engine/executor/MockGlideExecutor.java b/mocks/src/main/java/com/bumptech/glide/load/engine/executor/MockGlideExecutor.java index ab35c4e64f..e44e8903ff 100644 --- a/mocks/src/main/java/com/bumptech/glide/load/engine/executor/MockGlideExecutor.java +++ b/mocks/src/main/java/com/bumptech/glide/load/engine/executor/MockGlideExecutor.java @@ -27,7 +27,9 @@ public static GlideExecutor newMainThreadExecutor() { return newTestExecutor(new DirectExecutorService()); } - /** @deprecated Use {@link #newMainThreadExecutor} instead. */ + /** + * @deprecated Use {@link #newMainThreadExecutor} instead. + */ @Deprecated public static GlideExecutor newMainThreadUnlimitedExecutor() { return newMainThreadExecutor();