Move AgentWorker construction and registration out of AgentPool #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take on #954 that reduces the diff somewhat.
The aim here is to decouple the AgentPool from the creation of AgentWorkers and registration. This allows better composition and pushes the construction of dependencies up to the caller, which is the cli command level.
The only practical difference in how things work here is that there is a single signal handler for the whole AgentPool vs one for each AgentWorker. This shouldn't have anything other than aesthetic difference.
Registration and fetching of tags are now different things too, and the results are passed into things that need them.