Enabling no-command-eval will also disable use of plugins
#690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lox
reviewed
Mar 15, 2018
clicommand/agent_start.go
Outdated
| @@ -231,7 +231,7 @@ var AgentStartCommand = cli.Command{ | |||
| }, | |||
| cli.BoolFlag{ | |||
| Name: "no-command-eval", | |||
| Usage: "Don't allow this agent to run arbitrary console commands", | |||
| Usage: "Don't allow this agent to run arbitrary console commands. Turning off command eval will also disallow this agent to use plugins.", | |||
There was a problem hiding this comment.
Might "Don't allow this agent to run arbitrary console commands, including plugins" be terser?
|
@lox yah yah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #674