fallback to TASKKILL on windows #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @adill! I'm sorry you've had to put up with this for so long! We're working hard on much better windows support for the v3 release. I don't see any reason why we can't get this into 2.6 though. @keithpitt any objections? |
|
Could I trouble you to add some comments to explain why this is implemented this way? |
|
Looking forward to improved Windows support in v3! I've added the requested commentary. Thanks! |
|
Thanks very much @adill! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
This may be too much of a kludge for you folks but at Discord we've been frustrated by the inability to cancel Windows jobs for ages. This fallback seems to work and I wonder if you are interested in merging it until a proper long-term fix is available?
Related issues: #213 #345
For any drive-by readers I've hosted build 2.6.6 + this fix over on our fork. YMMV, caveat emptor, etc.