Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILDKITE_GCS_ACCESS_HOST for GCS Host choice #532

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Add BUILDKITE_GCS_ACCESS_HOST for GCS Host choice #532

merged 1 commit into from
Sep 18, 2017

Conversation

jules2689
Copy link
Contributor

@jules2689 jules2689 commented Aug 29, 2017

Problem

  • The URL for artifacts uploaded to GCS are api links.
  • Following the link in browser yields an XML error page.
  • The URL buildkite puts is under storage.googleapis.com but to leverage the oath prompt mentioned above users need to access objects under storage.cloud.google.com.
  • I couldn't find anything from buildkite's doc equivalent to BUILDKITE_S3_ACCESS_URL for Google Cloud.

Alternatives

  • When a user clicks a link in browser, you should use storage.cloud.google.com.
    • This flow is for humans, not machines - so it should be optimized for that experience
  • When a user fetches a link via API, you should use storage.googleapis.com
    • This flow is for machines, not humans - so it should be optimized for that experience

This change would be simple but allow for us to easily leverage oAuth and API when needed.

Looking at our internal issue again, I think @mcgain has asked about this - so best to get his input 😄 I saw this pattern in S3 Uploader, so I copied.

cc @keithpitt @toolmantim

@mcgain
Copy link

mcgain commented Aug 30, 2017

In #528 I suggested BUILDKITE_GCS_ACCESS_URL to be consistent with BUILDKITE_S3_ACCESS_URL.

I agree that the alternatives are preferable, but I'm not sure whether they scale to other providers.

@jules2689
Copy link
Contributor Author

Ah yea, I chose _HOST here to be consistent with the use of the env

@lox
Copy link
Contributor

lox commented Sep 18, 2017

Sorry for the slow response!

This seems like a good incremental solution to me. We have similar issues with BUILDKITE_S3_ACCESS_URL where we need to come up with a way to serve that url, but signed for authentication. When we tackle that, we can figure out a way to improve the click to download experience for the GCS stuff too.

@lox lox merged commit 70902a5 into buildkite:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants