add option to enable job log file #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskyb
requested changes
Mar 29, 2022
There was a problem hiding this comment.
thanks for your contribution @albertywu! i'm happy with the implementation here but i'm keen to iterate a little bit on the flag/envar names
albertywu
force-pushed
the
add-logging-to-file
branch
from
2325061 to
05cd627
Compare
|
@albertywu works on my machine ¯\_(ツ)_/¯ |
moskyb
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
@albertywu LGTM 🎉
i'll roll this into the next minor version update we do
moskyb
added
the
awaiting-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new agent config option
--enable-job-log-file.When set, all logs for a job are written to a temporary file and exposed to the job via an environment variable
BUILDKITE_JOB_LOG.This log file can be used by post-command, pre-exit, and exit hooks to analyze the logs without having to fetch them via API (which is slower, and subject to race conditions). One use-case we have for this is log failure analysis of the command-step to enable dynamic retries.
This temporary file is deleted when the job finishes.