Add sidecar Dockerfile and build steps #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 26, 2020
pda
approved these changes
Aug 7, 2020
|
Hmm, this has broken our release pipeline: https://buildkite.com/buildkite/agent-release-edge/builds/294#8d50db3e-781c-4690-9378-f1ddf83988be I'll look into why |
yob
added a commit
that referenced
this pull request
Aug 9, 2020
In #1218 we added a new docker image to the build and release, but we forgot to pass the meta_data through to the release pipeline. This resulted in the release pipeline failing - eg: https://buildkite.com/buildkite/agent-release-edge/builds/294#8d50db3e-781c-4690-9378-f1ddf83988be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces https://github.com/buildkite/buildkite-sidecar and the keithduncan/buildkite-sidecar Docker Hub repository by tagging
buildkite/agent:X-sidecardirectly at the source.Something I haven’t yet included is the environment hook that I used to print
BUILDKITE_ABOUT_*variables in the build log. I’ve found that useful for my builds but I’m not sure whether to include for all sidecars?cc @chloeruka @pda